Conversation
This reverts commit 5a37ad4.
moustachu
left a comment
moustachu
left a comment
There was a problem hiding this comment.
Hello,
The DECIDIM_AI_ENABLED is set to true by default.
In our case, we want this flag to be false by default when the environment variable is missing (which will be the case on most of our platform when updating the v3.8+ version)
We should update the default value here :
Thanks! Indeed! I did the change request, but I'm not sure ... I update for ai:enabled, AND ALSO:
|
|
I'm not sure for :
I think we should leave them at true by default. We only need ai:enabled because it's the one used on this PR. |
* Revert "Update issue templates" This reverts commit 5a37ad4. * add condition * add condition in a method decidim_ai_disabled? * update default flag of decidim_ai to false * update default value and delete decidim_ai reference in text mail * debug CI, search clue * fix CI by disabled Redis for Decidim_Ai in test * initialize decidim_ai_enabled to false before secrets * fix CI * fix CI * test CI * add config analyzer in first place * clean * refacto --------- Co-authored-by: moustachu <moustachu@opensourcepolitics.eu>
3 participants
🎩 Description
Stop digest mail of decidim_ai if Decidim_ai is disabled
Testing
Follow the steps here with changing the activation of decidim_ai <-> true <-> false
in console with:
Rails.application.secrets[:decidim][:ai][:enabled] = falseRails.application.secrets[:decidim][:ai][:enabled] = trueSee that you receive or not, the email in letter_opener or in sidekiq tab log [✅ EMAIL SENT]
📌 Related Issues
https://github.com/orgs/OpenSourcePolitics/projects/26/views/1?filterQuery=decidim-ai&pane=issue&itemId=154971976&issue=OpenSourcePolitics%7Cintern-tasks%7C357
PR digest mail
Tasks
🛠️ If your PR introduces or updates an Override
📷 Screenshots
Please add screenshots of the changes you're proposing if related to the UI
Extra information